[Quagga-bugs] [Bug 288] ospfd losts all routes when someone add/remove ip from box and router-id isn't set

[bugzilla-daemon at allevil.dishone.st]

Please do not reply directly to this email. All additional  
comments should be made in the comments box of this bug  
report.  
  
http://bugzilla.quagga.net/show_bug.cgi?id=288  
  




------- Additional Comments From ajschorr at alumni.princeton.edu  2006-07-21 00:44 -------
Created an attachment (id=96)
 --> (http://bugzilla.quagga.net/attachment.cgi?id=96&action=view)
make sure not to set a zero router id

In other words, shouldn't the logic be centralized in the
ospf_router_id_update routine as in this patch?  But I'm
not sure whether the logic in the patch is best.  Should
we freeze the router ID unless there's a static override,
or should we allow zebra to change it?

Regards,
Andy

------- Additional Comments From paul at dishone.st  2006-07-21 12:02 -------
Andy,

Yes, static updates should continue to work (to the extent ospfd works with
router-ID change at least), but unneeded updates should be avoided generally I
think, particularly when the router-ID changing in ospfd doesn't always work
reliably (or other neighbours aren't handling it reliably?). What's happening in
Yanek's case is that he is adding a new, higher IP, and zebra decides its a
better choice for router-ID, but there's no real reason for ospfd to change.

I had thought about putting it in the general router_id_update function (in
ospfd.c) too, but it's not as easy to detect the zebra router-id changing from
!0 to !0 there - which is the problem Yanek hit - your patch will still have
ospfd go through router-ID change when zebra sends additional router-id update
messages, won't it?
  
  
  
  
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.