[quagga-dev 4202] Re: possible ospfd bug: in state ExStart with routers that are neither DR nor BDR

[Paul Jakma]

On Fri, 30 Jun 2006, Paul Jakma wrote:

> Also, what about the attached patch. Consolidates some stuff and, I 
> think, adds a required 'tear-down' of adjacency state where the 
> transition is only to 2-Way/ExStart (hence doesn't pass through 
> nsm_reset_nbr) - seems like a latent bug. ??

I've split it up into small commits, might be easier to read, see:

http://cvs.quagga.net/cgi-bin/gitweb.cgi?p=people/paul/quagga;a=shortlog

Starting from:

 	[ospfd] consolidate adjacency check logic

the last one:

  http://cvs.quagga.net/cgi-bin/gitweb.cgi?p=people/paul/quagga;a=commitdiff;h=e4a3ea5052eec531128f2455087b5e9227729172;hp=3766b4316c7e97532b904f7112598c14fd064588

seems like a genuine bugfix to me (only ospf_ls_retransmit_clear is 
called when an adjacency drops to 2Way, and then /only/ if it drops 
out of Full..).

?

regards,
-- 
Paul Jakma	paul at clubi.ie	paul at jakma.org	Key ID: 64A2FF6A
Fortune:
Always the dullness of the fool is the whetstone of the wits.
 		-- William Shakespeare, "As You Like It"