[quagga-dev 4196] Re: possible ospfd bug: in state ExStart with routers that are neither DR nor BDR

[Andrew J. Schorr]

On Thu, Jun 29, 2006 at 05:08:53PM -0400, Andrew J. Schorr wrote:
> --- ospfd/ospf_nsm.c	29 Jun 2006 20:20:52 -0000	1.15
> +++ ospfd/ospf_nsm.c	29 Jun 2006 21:08:31 -0000
> @@ -203,8 +203,8 @@ nsm_twoway_received (struct ospf_neighbo
>      next_state = NSM_ExStart;
>  
>    /* Neighboring Router is the DRouter or the BDRouter. */
> -  if (IPV4_ADDR_SAME (&nbr->address.u.prefix4, &nbr->d_router) ||
> -      IPV4_ADDR_SAME (&nbr->address.u.prefix4, &nbr->bd_router))
> +  if (IPV4_ADDR_SAME (&nbr->address.u.prefix4, &DR(oi)) ||
> +      IPV4_ADDR_SAME (&nbr->address.u.prefix4, &BDR(oi)))
>      next_state = NSM_ExStart;
>  
>    return next_state;

So I applied this patch, and bounced the link a few times, and the
problem has not recurred.  Does this patch look right?  Should I commit
it?

Regards,
Andy