[quagga-dev 1330] Re: ospfd dies -- bug in ospf_spf_consider_nexthop

Andrew J. Schorr aschorr at telemetry-investments.com
Thu Jul 1 15:35:38 BST 2004


On Thu, Jul 01, 2004 at 09:29:26AM +0100, Paul Jakma wrote:
> >The question that still remains is whether to fix the 
> >LISTNODE_DELETE macro as I discussed in [quagga-dev 1295].  So far, 
> >there are no uses of LISTNODE_DELETE except for Kir's patch.  If we 
> >are going to keep that macro, I think it should be fixed, and it 
> >should be used in the listnode_delete function (to reduce code 
> >duplication).
> 
> Hmm, LISTNODE_DELETE is useful to shuffle a listnode from one list to 
> another.

But how useful is it really?  It's currently not used anywhere in the code...

> I dont think it should be changed, I think all normal list users 
> should use the function. Perhaps a comment by LISTNODE_DELETE would 
> be enough to fix the not-a-problem, or rename it to LISTNODE_DETACH 
> or somesuch to make it more obvious. (ditto for LISTNODE_ADD, 
> s/ADD/ATTACH/)

I would agree that it should be renamed if kept as is.  It's quite
confusing, in my opinion, if the function listnode_delete calls listnode_free,
but the macro LISTNODE_DELETE does not.

-Andy



More information about the Quagga-dev mailing list