[quagga-dev 3089] Re: strlcpy implementation correct?

Hasso Tepper hasso at estpak.ee
Sat Apr 2 19:02:36 BST 2005


Andrew J. Schorr wrote:
> On Sat, Apr 02, 2005 at 08:01:49PM +0300, Hasso Tepper wrote:
> > Sure, look at toplevel comment in str.c. Replacing these have been in
> > my todo list, but haven't time for it yet. I have always something more
> > important todo ;). Feel free to replace these with any GPL'ed
> > strlcat/stlcpy implementations.
>
> Yes, the comment is infuriating.  Why would somebody bother to implement
> functions that do not work correctly?  This causes bugs in the code.

Well, I think that you know the answer ... ;)

> Yes, openssh has it, and so does rsync.  Rsync is GPL, so could take
> from there.  I'm not sure it's the greatest implementation...

I think that it's good enough. There have been quite many eyes on rsync code 
probably ;).


-- 
Hasso Tepper
Elion Enterprises Ltd.
WAN administrator



More information about the Quagga-dev mailing list