[quagga-dev 3117] Re: list loop cleanup/audit

Hasso Tepper hasso at estpak.ee
Tue Apr 5 16:33:56 BST 2005

Paul Jakma wrote:
> The ever popular list loop cleanup.
> Attached is the linklist.h and ChangeLog diff.
> The old macros are preserved inside a 'QUAGGA_DEPRECATED' define,
> which should be set to a date. This possibly could be done a wee bit
> better..

This prints warning every time linklist.h is included. The point would be to 
print the warning is deprecated macros is used.

> The full diff, large, removing LIST_LOOP and auditing just about
> every list loop in the tree is at:
> http://hibernia.jakma.org/~paul/patches/quagga-listloops-cleanup.diff

I don't like to see changes _not_ related to the listloop cleanup already in 
huge patch. For example last chunk in the ospf6d/ospf6_abr.c. Btw, see 
HACKING, -p is recommended to use with diff.

Hasso Tepper
Elion Enterprises Ltd.
WAN administrator

More information about the Quagga-dev mailing list