[quagga-dev 3140] Re: [PATCH] netlink fixes

Hasso Tepper hasso at estpak.ee
Sat Apr 9 17:54:50 BST 2005


Hasso Tepper wrote:
> Some things annoyed me some time already in netlink debug output.
>
> 1) IPv6 routes were not logged correctly.
> 2) Useless (wrong) info was logged with routes add/remove messages.
> 3) IFA_ADDRESS debug was logged in starnge format - eth0/24 10.10.10.1
>
> Attached patch fixes this. It also fixes one unsigned/signed warning in
> rt_netlink.c. I'm not yet sure how to fix two more warnings in this file.

Commited now.

> One question raised while testing patch though. Testing was done in
> laptop with 10.10.10.0/24 and dead:beaf::/64 networks in eth0. Two static
> routes were added - "ip route 10.30.30.0/24 10.10.10.1" and "ipv6 route
> 3ffe::/64 dead:beaf::1". With this patch applied debug output:
>
> 2005/04/08 14:46:10 ZEBRA: netlink_route_multipath() (single hop):
> RTM_NEWROUTE 10.30.30.0/24, type IPv4 nexthop
> 2005/04/08 14:46:10 ZEBRA: netlink_route_multipath() (single hop):
> nexthop via 10.10.10.1 if 2
>
> 2005/04/08 14:46:45 ZEBRA: netlink_route_multipath() (single hop):
> RTM_NEWROUTE 3ffe::/64, type IPv6 nexthopIPv6 nexthop with ifindex
> 2005/04/08 14:46:45 ZEBRA: netlink_route_multipath() (single hop):
> nexthop via dead:beef::2 if 2
>
> Why both "IPv6 nexthop" and "IPv6 nexthop with ifindex" in case of IPv6?
> Shouldn't IPv6 nexthop be enough in case of global nexthop?

Doh, forget about it. Really stupid typo in rt_netlink.c, will go to fix 
now.


-- 
Hasso Tepper
Elion Enterprises Ltd.
WAN administrator



More information about the Quagga-dev mailing list