[quagga-dev 4305] ospf default-information strangeness

Andrew J. Schorr aschorr at telemetry-investments.com
Thu Aug 17 00:05:45 BST 2006


Just curious about this code in
ospfd/ospf_zebra.c:ospf_redistribute_default_set():

  int force = 0;

  if (ospf_is_type_redistributed (DEFAULT_ROUTE))
    {
      if (mtype != ospf->dmetric[DEFAULT_ROUTE].type)
        {
          ospf->dmetric[DEFAULT_ROUTE].type = mtype;
          force = 1;
        }
      if (mvalue != ospf->dmetric[DEFAULT_ROUTE].value)
        {
          force = 1;
          ospf->dmetric[DEFAULT_ROUTE].value = mvalue;
        }
  ...

The "force" variable is never referenced in this function (just set).
It seems to me that either the variable should be removed, or there's
some missing code that needs to be added that will take action based
on whether force is non-zero.

Does anybody know which is correct?

Regards,
Andy



More information about the Quagga-dev mailing list