[quagga-dev 4164] patch for redhat/quagga.spec.in

Andrew J. Schorr aschorr at telemetry-investments.com
Thu Jun 15 22:45:43 BST 2006


Hi,

I see two (minor) problems with the current redhat/quagga.spec.in:

1. It defines dist_default as fc4, but it then uses default_dist
as a default value for dist.  So the variable name is reversed
(default_dist instead of dist_default).

2. It seems much nicer to detect the release automatically (instead
of hard-coding fc4).

I propose the attached patch.  Does that look good?

Regards,
Andy
-------------- next part --------------
Index: redhat/quagga.spec.in
===================================================================
RCS file: /var/cvsroot/quagga/redhat/quagga.spec.in,v
retrieving revision 1.30
diff -b -u -p -r1.30 quagga.spec.in
--- redhat/quagga.spec.in	20 Nov 2005 02:09:32 -0000	1.30
+++ redhat/quagga.spec.in	15 Jun 2006 21:29:34 -0000
@@ -39,8 +39,8 @@
 ############################################################################
 
 ####################### distro specific tweaks #############################
-# default distro. Override with rpmbuild -D "dist_default XXX" 
-%define			dist_default		fc4
+# default distro. Override with rpmbuild -D "dist XXX" 
+%{expand: %%define default_dist %(rpm -q --qf 'fc%%{VERSION}' fedora-release | grep -v 'not installed')}
 %{!?dist:		%define		dist	%{default_dist}}
 
 # as distros change packages we depend on, our Requires have to change, sadly.


More information about the Quagga-dev mailing list