[quagga-dev 4169] Re: minor patch to ospfd config_write_debug

Andrew J. Schorr aschorr at telemetry-investments.com
Fri Jun 23 16:34:43 BST 2006


Hi,

Thanks for that patch.

On Fri, Jun 23, 2006 at 10:42:21AM -0400, Erik Muller wrote:
> --- quagga-0.99.1-dist/ospfd/ospf_nsm.c	Sat Dec 11 13:00:06 2004
> +++ quagga-0.99.1/ospfd/ospf_nsm.c	Fri May 27 11:04:22 2005
> @@ -690,6 +690,13 @@ nsm_change_state (struct ospf_neighbor *
>    if ((old_state != NSM_Full && state == NSM_Full) ||
>        (old_state == NSM_Full && state != NSM_Full))
>      {
> +      /* Optionally notify when a neighbor enters or leaves Full */
> +      if (CHECK_FLAG (oi->ospf->config, OSPF_LOG_ADJACENCY_CHANGES))
> +        zlog_notice ("AdjChg Nbr %s via %s, %s -> %s",
> +		    inet_ntoa (nbr->router_id), IF_NAME (nbr->oi),
> +		    LOOKUP (ospf_nsm_state_msg, old_state),
> +		    LOOKUP (ospf_nsm_state_msg, nbr->state));
> +

I have one question about this: the log message occurs only when
there's a state transition into or out of "Full".  Does that match
the logic in IOS regarding when to report an adjacency change?
For example, suppose there are two routers on an ethernet
network, and neither one is the DR or BDR.  Should a message
be logged when the routers enter (or fall out of) "2-Way/DROther" state?

Regards,
Andy



More information about the Quagga-dev mailing list