[quagga-dev 4383] Re: ospf default-information strangeness

Andrew J. Schorr aschorr at telemetry-investments.com
Fri Sep 22 21:09:39 BST 2006


Is there any objection to my committing this patch?
In other words, is there some good reason to call
ospf_external_lsa_refresh_default(ospf) even if the
metric-type and metric have not changed (i.e. the
user had already run 'default-information originate' with
the same metric and metric-type)?

Regards,
Andy
-------------- next part --------------
Index: ospfd/ospf_zebra.c
===================================================================
RCS file: /var/cvsroot/quagga/ospfd/ospf_zebra.c,v
retrieving revision 1.40
diff -b -u -p -r1.40 ospf_zebra.c
--- ospfd/ospf_zebra.c	12 May 2006 23:02:46 -0000	1.40
+++ ospfd/ospf_zebra.c	22 Sep 2006 20:05:26 -0000
@@ -591,6 +591,10 @@ ospf_redistribute_default_set (struct os
           ospf->dmetric[DEFAULT_ROUTE].value = mvalue;
         }
 
+      if (!force)
+        /* nothing changed */
+	return CMD_SUCCESS;
+
       ospf_external_lsa_refresh_default (ospf);
 
       if (IS_DEBUG_OSPF (zebra, ZEBRA_REDISTRIBUTE))


More information about the Quagga-dev mailing list