[quagga-dev 5042] Re: [PATCH] [ospfd] Ignore silently O bit in hello packets
paul at clubi.ie
Wed Aug 22 18:11:59 BST 2007
On Wed, 22 Aug 2007, Andrew J. Schorr wrote:
> A neighbor is opaque-capable if and only if it sets
> the O-bit in the Options field of its Database Description packets;
> the O-bit is not set in packets other than Database Description.
> That seems to say that the O-bit should not be set in anything
> other than a DD packet.
It says something about DD only. It doesn't say anything about other
packets ;). Which is Hasso's point.
> Why not simply move the warning message inside the
> '#ifdef STRICT_OBIT_USAGE_CHECK' test?
> Doesn't that solve your problem with a smaller change?
Well, it's just dead-code. There's no point ever having it enabled if
one accepts Postel's robustness principle.
Paul Jakma paul at clubi.ie paul at jakma.org Key ID: 64A2FF6A
I can give you my word, but I know what it's worth and you don't.
-- Nero Wolfe, "Over My Dead Body"
More information about the Quagga-dev