[quagga-dev 6225] Re: [PATCH] [lib] Fix Fletcher checksum error.

Joakim Tjernlund joakim.tjernlund at transmode.se
Mon Dec 1 15:41:26 GMT 2008


On Sun, 2008-11-30 at 11:52 +0000, paul at clubi.ie wrote:
> On Sun, 30 Nov 2008, Joakim Tjernlund wrote:
> 
> > I did test this, both with my own simplified tests that discovered 
> > the original Fletcher error and with your test suite. It has also 
> > been tested by others on the list. The only change that doesn't 
> > have a dedicated test suite is the in_chksum change but that one is 
> > trivial.
> 
> Well, you may have all faith in it - however I don't have faith in 
> /my/ ability to review it properly ;). It really needs a unit test.

Well, so I added a simple test. Pushed to volatile/for_paul_stable
Here is the commit msg:

[tests] Add test for Internet checksum.

Add 2 impl. of the Internet Checksum. One new optimized and
one from RFC 1071. Turns out that the current Quagga in_cksum()
is buggy. On Big Endian routers it miscalculates odd sized buffers.



More information about the Quagga-dev mailing list