[quagga-dev 5260] Re: cosmetic show command patch to bgpd/bgp_vty.c

Paul Jakma Paul.Jakma at Sun.COM
Wed Feb 13 15:18:58 GMT 2008


On Tue, 12 Feb 2008, Michael Larson wrote:

> If the ASN specified is larger than the max positive value of a signed 
> int--the quagga show command show ip bgp summary will overflow the AS 
> value:
>
> Where AS = 4294967294
>
> # show ip bgp summary
> BGP router identifier 200.0.0.1, local AS number -2
> RIB entries 0, using 0 bytes of memory

> I've attached a small patch (bgpd/bgp_vty.c) that fixes the sprintf 
> statement in 3 places for bgp AS output. thanks!

Oops. Cheers for that.

Why not just use %u though? (as_t is unlikely to change again in the 
foreseeable future).

regards,
-- 
Paul Jakma,
Solaris Networking                       Sun Microsystems, Scotland
http://opensolaris.org/os/project/quagga tel: EMEA x73150 / +44 15066 73150



More information about the Quagga-dev mailing list