[quagga-dev 5277] Re: mes_lookup / LOOKUP robustness

Andrew J. Schorr aschorr at telemetry-investments.com
Wed Feb 27 13:16:52 GMT 2008


On Wed, Feb 27, 2008 at 01:24:25PM +0300, Denis Ovsienko wrote:
> Hello.
> 
> [...]
> > sequence, so we downgraded it to a debug message).  If the function
> > is called with 1 or more invalid arguments, perhaps we should just
> > call abort()?
> 
> The only matter I don't agree on is that *lookup() calls are mostly
> employed in debugging functions, so enabling a debug option could
> trigger a crash instead of helping to pin down a less drastic bug. The
> rest is quite reasonable.

Ah yes, that's an important point.  I was (incorrectly) assuming that
any bugs would be found very quickly, but that would not be the case
if the code is rarely touched...

Regards,
Andy



More information about the Quagga-dev mailing list