[quagga-dev 5505] Re: [PATCH] bgp: fix double free in route server client

paul at clubi.ie paul at clubi.ie
Tue Jun 17 10:59:29 BST 2008


On Mon, 16 Jun 2008, Stephen Hemminger wrote:

> Deleting a neighbor with route server client results in double free
> of bgp_table.  The fix is to just null the entry after freeing as per
> other allocations in BGP.

> Probably fixes http://bugzilla.quagga.net/show_bug.cgi?id=410

Ah, well spotted.

Could you make bgp_table_finish take a double-pointer, and have it 
set the freed field to NULL there instead?

Probably should make that a general style rule for free-like 
functions..

regards,
-- 
Paul Jakma	paul at clubi.ie	paul at jakma.org	Key ID: 64A2FF6A
 	http://www.quagga.net/commercial.php#jakma
Fortune:
Thank you for observing all safety precautions.



More information about the Quagga-dev mailing list