[quagga-dev 5522] typo/mixup?

Joakim Tjernlund joakim.tjernlund at transmode.se
Mon Jun 23 16:26:06 BST 2008


Stumbled across this.

In RFC 1850 you have:
ospfIfState OBJECT-TYPE
        SYNTAX   INTEGER    {
                    down (1),
                    loopback (2),
                    waiting (3),
                    pointToPoint (4),
                    designatedRouter (5),
                    backupDesignatedRouter (6),
                    otherDesignatedRouter (7)
                  }

In ospf_ism.h you have:
/* OSPF Interface State Machine Status. */
#define ISM_DependUpon                    0
#define ISM_Down                          1
#define ISM_Loopback                      2
#define ISM_Waiting                       3
#define ISM_PointToPoint                  4
#define ISM_DROther                       5
#define ISM_Backup                        6
#define ISM_DR                            7
#define OSPF_ISM_STATE_MAX   	          8

Notice how ISM_DR and ISM_DROther is numerically swapped
with otherDesignatedRouter and designatedRouter.

bug or perhaps it doesn't matter? Either way it would look nicer
if these were aligned.

 Jocke



More information about the Quagga-dev mailing list