[quagga-dev 5523] Re: typo/mixup?

paul at clubi.ie paul at clubi.ie
Tue Jun 24 11:03:00 BST 2008


On Mon, 23 Jun 2008, Joakim Tjernlund wrote:

> #define ISM_DROther                       5
> #define ISM_Backup                        6
> #define ISM_DR                            7
> #define OSPF_ISM_STATE_MAX   	          8
>
> Notice how ISM_DR and ISM_DROther is numerically swapped
> with otherDesignatedRouter and designatedRouter.
>
> bug or perhaps it doesn't matter? Either way it would look nicer
> if these were aligned.

I guess you could change it, as long as you changed all occurances of 
code that relies on the ordering, e.g. by using (x < ISM_DROther) to 
test for states other than DROther, Backup or DR - and there was some 
there was tangible benefit to justify the churn and risk.

regards,
-- 
Paul Jakma	paul at clubi.ie	paul at jakma.org	Key ID: 64A2FF6A
Fortune:
It's the thought, if any, that counts!



More information about the Quagga-dev mailing list