[quagga-dev 5883] Re: [PATCH 08/11] Update SPF calculation for unnumbered links.

Joakim Tjernlund joakim.tjernlund at transmode.se
Wed Sep 3 09:35:14 BST 2008


On Wed, 2008-09-03 at 08:59 +0100, paul at clubi.ie wrote:
> On Wed, 3 Sep 2008, Joakim Tjernlund wrote:
> 
> > Can't make this apply. Pretty much the whole patch conflicts
> > but I really see what is wrong. Any clue?
> 
> I tested the minor mods I made and they work, so I commited it. 
> Pushed to 'master' now.
> 
> Merged your 'ospf_neighbour', 'snmp_compile' branches and the "use 
> ALLSPF_ROUTERS as destination on PtP" commit on your unnumbered 
> tree.

OK, will update and take a look and adapt my ip ospf area commad.
When you are at it, you should apply this patch too:

Replying to Joakim Tjernlund:
> Least surprise principal. I don't want PIE and all of a sudden I get
> that automatically. Is PIE that safe/good to be on by default?

I consider PIE a mandatory thing wrt every piece of code that can be
potentially exploited.

It will not add any significant performance and/or other penalties
that can ruin your experience.

Having said that, there's a genuine bug in shell snipped in
configure.ac, the patch below fixes it:


>From 0100f616d14e92085e24bc59a82a35a531d69cfd Mon Sep 17 00:00:00 2001
From: Paul P. Komkoff Jr <i at stingr.net>
Date: Wed, 27 Aug 2008 10:37:44 +0100
Subject: [PATCH] Fix PIE test to be actually triggerable

---
 configure.ac |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 87ec96c..e03b513 100755
--- a/configure.ac
+++ b/configure.ac
@@ -1398,10 +1398,8 @@ CONFDATE=`date '+%Y%m%d'`
 AC_SUBST(CONFDATE)
 
 dnl Conditionally enable PIE support for GNU toolchains.
-enable_pie=yes
-
 AC_ARG_ENABLE(pie, AS_HELP_STRING([--disable-pie], [Do not build tools
as a Position Independent Executables]))
-if test "$enable_pie" = "yes"; then
+if test "$enable_pie" != "no"; then
   AC_CACHE_CHECK([whether $CC accepts PIE flags], [ap_cv_cc_pie], [
     save_CFLAGS=$CFLAGS
     save_LDFLAGS=$LDFLAGS
-- 
1.5.6.4

-- 
Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key
 This message represents the official view of the voices in my head





More information about the Quagga-dev mailing list