[quagga-dev 7517] Re: [PATCH 00/11] More Quagga cleanups

Stephen Hemminger shemminger at vyatta.com
Thu Dec 10 01:15:12 GMT 2009


On Thu, 10 Dec 2009 00:03:20 +0100
Joakim Tjernlund <joakim.tjernlund at transmode.se> wrote:

> Stephen Hemminger <shemminger at vyatta.com> wrote on 09/12/2009 22:38:45:
> 
> > From: Stephen Hemminger <shemminger at vyatta.com>
> > To: Joakim Tjernlund <joakim.tjernlund at transmode.se>
> > Cc: quagga-dev at lists.quagga.net
> > Date: 09/12/2009 22:39
> > Subject: Re: [quagga-dev 7500] [PATCH 00/11] More Quagga cleanups
> >
> > On Wed, 9 Dec 2009 22:16:57 +0100
> > Joakim Tjernlund <joakim.tjernlund at transmode.se> wrote:
> >
> > > >
> > > > Note, these are all new, and not from Vyatta version.
> > >
> > > Could we stop the cleanup fixes? There are lots of
> > > patches fixing real problems that are likely going to clash
> > > with the cleanups.
> > >
> >
> > I don't see how removing dead code can interfere with any reasonable
> > tools for merge.
> 
> It doesn't, but I am surprised you make that comment. The series
> you just sent doesn't just remove dead code, does it?
> 
> If you volunteer to merge the outstanding patches, then please go ahead.
> 
>  Jocke
> 

About 1, 8, 9, and 11 remove dead code. 10 is a bug fix.
And 3 although it looks like a warning fix is actually a bug fix
for cases where %s is in banner or logmsg.

P.s: logmsg shows up in code and doc, but doesn't appear to work
from vtysh (strange).



More information about the Quagga-dev mailing list