[quagga-dev 7520] Re: [PATCH 00/11] More Quagga cleanups

Joakim Tjernlund joakim.tjernlund at transmode.se
Thu Dec 10 07:17:42 GMT 2009


Stephen Hemminger <shemminger at vyatta.com> wrote on 10/12/2009 02:15:12:
>
> On Thu, 10 Dec 2009 00:03:20 +0100
> Joakim Tjernlund <joakim.tjernlund at transmode.se> wrote:
>
> > Stephen Hemminger <shemminger at vyatta.com> wrote on 09/12/2009 22:38:45:
> >
> > > From: Stephen Hemminger <shemminger at vyatta.com>
> > > To: Joakim Tjernlund <joakim.tjernlund at transmode.se>
> > > Cc: quagga-dev at lists.quagga.net
> > > Date: 09/12/2009 22:39
> > > Subject: Re: [quagga-dev 7500] [PATCH 00/11] More Quagga cleanups
> > >
> > > On Wed, 9 Dec 2009 22:16:57 +0100
> > > Joakim Tjernlund <joakim.tjernlund at transmode.se> wrote:
> > >
> > > > >
> > > > > Note, these are all new, and not from Vyatta version.
> > > >
> > > > Could we stop the cleanup fixes? There are lots of
> > > > patches fixing real problems that are likely going to clash
> > > > with the cleanups.
> > > >
> > >
> > > I don't see how removing dead code can interfere with any reasonable
> > > tools for merge.
> >
> > It doesn't, but I am surprised you make that comment. The series
> > you just sent doesn't just remove dead code, does it?
> >
> > If you volunteer to merge the outstanding patches, then please go ahead.
> >
> >  Jocke
> >
>
> About 1, 8, 9, and 11 remove dead code. 10 is a bug fix.
> And 3 although it looks like a warning fix is actually a bug fix
> for cases where %s is in banner or logmsg.

So? You are just illustrating my point. Several of your patches does
more than code removal and I sure you are not done yet.

 Jocke




More information about the Quagga-dev mailing list