[quagga-dev 7931] Re: ospfd: connected routes not redistributed

Joakim Tjernlund joakim.tjernlund at transmode.se
Tue Apr 13 18:41:26 BST 2010

> Yeah, this addon patch is definitely a good thing, as it avoids reconfig
> deadlocks. I tested it successfully. If your creative mind stops producing
> more addon patches, please post an all-including patch together with the
> commit comments as requested by Greg.

Thanks, how about this then(on top the others)?

>From fa30cdaac469086274ff3030cc0f885246b1ad6e Mon Sep 17 00:00:00 2001
From: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
Date: Tue, 13 Apr 2010 19:33:35 +0200
Subject: [PATCH] ospfd: Do not force refresh of external default route.

ospf_distribute_list_update_timer() forces a refresh of
default route even when it hasn't changed while other
routes( static etc. ) are only refreshed as needed.
This makes default route refreash behave as any other external route.
 ospfd/ospf_zebra.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/ospfd/ospf_zebra.c b/ospfd/ospf_zebra.c
index 462f67c..efefd67 100644
--- a/ospfd/ospf_zebra.c
+++ b/ospfd/ospf_zebra.c
@@ -949,9 +949,7 @@ ospf_distribute_list_update_timer (struct thread *thread)
       for (rn = route_top (rt); rn; rn = route_next (rn))
 	if ((ei = rn->info) != NULL)
-	    if (is_prefix_default (&ei->p))
-	      ospf_external_lsa_refresh_default (ospf);
-	    else if ((lsa = ospf_external_info_find_lsa (ospf, &ei->p)))
+	    if ((lsa = ospf_external_info_find_lsa (ospf, &ei->p)))
 	      ospf_external_lsa_refresh (ospf, lsa, ei, LSA_REFRESH_IF_CHANGED);
 	      ospf_external_lsa_originate (ospf, ei);

More information about the Quagga-dev mailing list