[quagga-dev 8167] Re: [PATCH] Zebra zserv: bogus conditional

Greg Troxel gdt at ir.bbn.com
Fri Aug 20 19:26:25 BST 2010


Joakim Tjernlund <joakim.tjernlund at transmode.se> writes:

> Greg Troxel <gdt at ir.bbn.com> wrote on 2010/08/19 20:36:17:
>>
>>
>>   From: Joakim Tjernlund <joakim.tjernlund at transmode.se>
>>   Date: Thu, 19 Aug 2010 09:30:44 +0200
>>
>>   Shouldn't this info always be included when deleting routes? It is
>>   possible to have routes which only differs in metric so how to tell
>>   which one to delete?
>>
>> routes are key-value pairs.  AFAIK the key is protocol/prefix/length and
>> the metric is part of the value.  So I don't think it makes sense to
>> have two routes that differ only in metric, unless we're doing
>> equal-cost multipath and we need a way to specify the value as well.
>> But if we need that we should add it explicitly as a separate commit.
>
> It just doesn't feel right that that one uses a wider key to delete
> routes than when adding them.

Is the metric something matched by OS kernels in doing a lookup, or
something that is looked up?  I still think metric is part of the value,
not the key.

>> Are you saying that there are existing use cases which rely on this bug?
>
> No, just a reflection considering how broken Q's route deletion code is.

I can see your point, but decided that if there is an issue here it's a
layered issue beyond something that obviously should be fixed, and
having verified that nothing bad happens with the first fix, I did it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20100820/379fa3a4/attachment-0001.sig>


More information about the Quagga-dev mailing list