[quagga-dev 7753] Re: isisd patches?

David Lamparter equinox at diac24.net
Tue Feb 2 20:33:42 GMT 2010


Am Dienstag, den 02.02.2010, 21:20 +0100 schrieb Joakim Tjernlund:
> if you haven't alredy done so, could you look at getting of
> this error (OS Linux) message too?
> ./extract.pl /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/bgpd/*.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/isisd/*.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/ospfd/*.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/ospf6d/*.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/ripd/*.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/ripngd/*.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/lib/keychain.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/lib/routemap.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/lib/filter.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/lib/plist.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/lib/distribute.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/lib/if_rmap.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/lib/vty.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/zebra/debug.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/zebra/interface.c /usr/loca
>  l/src/TM-t2/ext/quagga/quagga-0.99.11-plus/zebra/irdp_interface.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/zebra/rtadv.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/zebra/zebra_vty.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/zebra/zserv.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/zebra/router-id.c /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/zebra/zebra_routemap.c
>  > vtysh_cmd.c
> /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/isisd/isis_bpf.c:28:21: error: net/bpf.h: No such file or directory
> /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/isisd/isis_dlpi.c:31:22: error: sys/dlpi.h: No such file or directory
> /usr/local/src/TM-t2/ext/quagga/quagga-0.99.11-plus/isisd/isis_dlpi.c:32:23: error: sys/pfmod.h: No such file or directory

That happens because isisd selects one of 3 system interface methods,
isis_pfpacket, isis_dlpi or isis_bpf. (cf. configure.ac line 788).
However, extract.pl reads isisd/*.c and therefore encounters these files
including headers that don't exist.

I'm quite unsure whether we should fix this at all; they're warnings but
they don't really matter much... 

If you want to fix it, replace isisd/*.c with
isisd/isis{d,_circuit,_spf}.c [expand that] in vtysh/Makefile.am line
24. But if you do that and someone adds DEFUN commands in some other
isis file, vtysh will be broken non-obviously...

(alternatively, we could wrap these 3 isis files in #ifdefs... hmm...)


-David





More information about the Quagga-dev mailing list