[quagga-dev 7596] [PATCH 07/10] ospfd: Fix debug messages that were masked by DISCARD_LSA

Paul Jakma paul at jakma.org
Mon Jan 11 16:48:19 GMT 2010


From: Paul Jakma <paul at quagga.net>

* ospf_packet.c: (ospf_ls_upd) DISCARD_LSA continues, and so should be
  after debug messages, not before them.
---
 ospfd/ospf_packet.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/ospfd/ospf_packet.c b/ospfd/ospf_packet.c
index 303d777..57ed114 100644
--- a/ospfd/ospf_packet.c
+++ b/ospfd/ospf_packet.c
@@ -1724,17 +1724,17 @@ ospf_ls_upd (struct ip *iph, struct ospf_header *ospfh,
         /* Reject from STUB or NSSA */
         if (nbr->oi->area->external_routing != OSPF_AREA_DEFAULT) 
 	  {
-	    DISCARD_LSA (lsa, 1);
 	    if (IS_DEBUG_OSPF_NSSA)
 	      zlog_debug("Incoming External LSA Discarded: We are NSSA/STUB Area");
+	    DISCARD_LSA (lsa, 1);
 	  }
 
       if (lsa->data->type == OSPF_AS_NSSA_LSA)
 	if (nbr->oi->area->external_routing != OSPF_AREA_NSSA)
 	  {
-	    DISCARD_LSA (lsa,2);
 	    if (IS_DEBUG_OSPF_NSSA)
 	      zlog_debug("Incoming NSSA LSA Discarded:  Not NSSA Area");
+	    DISCARD_LSA (lsa,2);
 	  }
 
       /* Find the LSA in the current database. */
@@ -1953,7 +1953,8 @@ ospf_ls_upd (struct ip *iph, struct ospf_header *ospfh,
 	    }
 	}
     }
-  
+#undef DISCARD_LSA
+
   assert (listcount (lsas) == 0);
   list_delete (lsas);
 }
-- 
1.6.5.2




More information about the Quagga-dev mailing list