[quagga-dev 8023] [PATCH] bgpd: allow overwrite of existing aggregate-address parameter

Robert Bays robert at vyatta.com
Tue Jun 8 01:10:23 BST 2010


In bgpd, I can update the network statement without having to delete it
first.  i.e.

vyatta# conf t
vyatta(config)# router bgp 10
vyatta(config)# network 10.0.0.0/8
vyatta(config)# network 10.0.0.0/8 backdoor

However, a similar configuration for aggregate-address forces me to
delete the original aggregate first.  i.e.

vyatta# conf t
vyatta(config)# router bgp 10
vyatta(config)# aggregate-address 10.0.0.0/8
vyatta(config)# aggregate-address 10.0.0.0/8 summary-only
  "There is already same aggregate network."
vyatta(config)# no aggregate-address 10.0.0.0/8
vyatta(config)# aggregate-address 10.0.0.0/8 summary-only

Trivial, I know, but helpful in our implementation.  The attached patch
allows for updating an aggregate-address parameter without first
explicitly deleting it.

I'm not usually a coder these days, so I have a couple of questions...
First, in bgp_aggregate_set() would you prefer to see me delete and free
the aggregate directly rather than calling bgp_aggregate_unset()?
Second, is there a reason bgp_unlock_node(rn) is being called twice in a
row in the various bgp_static/aggregate/distance_unset() functions?

Thanks.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bgpd.patch
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20100607/268a1f63/attachment-0001.ksh>


More information about the Quagga-dev mailing list