[quagga-dev 8374] Re: [PATCH 7/7] ospf6d: Remove obsolete code

Balaji G balajig81 at gmail.com
Tue Nov 30 14:18:35 GMT 2010


Hi Greg

>Balaji has been taking patches mailed to the list and storing them in
>his git repository (see HACKING and HACKING.pending), which I
>appreciate.  Patches sent to the list often don't have commit messages,
>though, and those are very important.  If the only issue is not being
>able to publish a git repository, then emailed patches with git
>format-patch are fine, because those end up with commit messages after
>git am.

Thanks. I have the quagga-mbgp branch in the git hub and the code is also
available in quagga.net. I have created an other repo called quagga-devel in
git hub which contains a clone of quagga-next . Is it possible for you to
take in those changes as such ? Paul had done a round of review of that. and
i am making changes in the CLI too to make it Cisco like as there are lot of
repetitions in the CLI. I would also work on other features and fixes and
push them into quagga-devel soon.

Let me know how do you wanna proceed on this.

Cheers,
  - Balaji



On Tue, Nov 30, 2010 at 6:41 PM, Greg Troxel <gdt at ir.bbn.com> wrote:

>
> @balaji: Thanks for explaining this and keeping patches organized.
>
> @quagga-dev:
>
> I have indeed been trying to apply some patches.  The basic difficulty
> is that I feel the existing codebase is fragile and underdocumented in
> terms of calling conventions, invariants, etc.  Reviewing each patch to
> be sure that it won't cause regressions is very tricky, and I've found
> that I'm not comfortable yet with a significant number of them.
>
> I did put one on a branch and asked for regression testing, but haven't
> yet heard any reports.  It's on feature.bgp-vty-view-af.  If a few
> people running BGP for real told me that they updated to that and it was
> fine, I'd merge it master.
>
> I will be trying to examine patches and for each either apply it,
> feature branch it and call for testing, or explain on quagga-dev why I
> didn't do one of those.
>
> It's easiest for me if proposed changes are in a publically-accessible
> git repository that's essentially a clone of the official repository,
> with each logically-related group of changes on a feature branch off
> master.  That means changes can be merged independently.
>
> Balaji has been taking patches mailed to the list and storing them in
> his git repository (see HACKING and HACKING.pending), which I
> appreciate.  Patches sent to the list often don't have commit messages,
> though, and those are very important.  If the only issue is not being
> able to publish a git repository, then emailed patches with git
> format-patch are fine, because those end up with commit messages after
> git am.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20101130/8953eada/attachment-0001.html>


More information about the Quagga-dev mailing list