[quagga-dev 8987] Re: [PATCH 8/8] fix set never used warnings

Denis Ovsienko infrastation at yandex.ru
Tue Dec 6 21:56:09 GMT 2011


Seven other patches are merged, but this one is likely to break things without those stream_getl() calls. Are you sure?


> @@ -1516,14 +1511,7 @@ bgp_mp_reach_parse (struct peer *peer, c
>          memcpy(&attr->nexthop.s_addr, &attre->mp_nexthop_global_in, 4);
>        break;
>      case 12:
> -      {
> - u_int32_t rd_high;
> - u_int32_t rd_low;
> -
> - rd_high = stream_getl (s);
> - rd_low = stream_getl (s);
> - stream_get (&attre->mp_nexthop_global_in, s, 4);
> -      }
> +      stream_get (&attre->mp_nexthop_global_in, s, 4);
>        break;
>  #ifdef HAVE_IPV6
>      case 16:


> @@ -258,10 +256,7 @@ zebra_read_ipv4 (int command, struct zcl
>        nexthop.s_addr = stream_get_ipv4 (s);
>      }
>    if (CHECK_FLAG (api.message, ZAPI_MESSAGE_IFINDEX))
> -    {
>        api.ifindex_num = stream_getc (s);
> -      ifindex = stream_getl (s);
> -    }
>    if (CHECK_FLAG (api.message, ZAPI_MESSAGE_DISTANCE))
>      api.distance = stream_getc (s);
>    if (CHECK_FLAG (api.message, ZAPI_MESSAGE_METRIC))


> @@ -336,10 +329,7 @@ zebra_read_ipv6 (int command, struct zcl
>        stream_get (&nexthop, s, 16);
>      }
>    if (CHECK_FLAG (api.message, ZAPI_MESSAGE_IFINDEX))
> -    {
>        api.ifindex_num = stream_getc (s);
> -      ifindex = stream_getl (s);
> -    }
>    if (CHECK_FLAG (api.message, ZAPI_MESSAGE_DISTANCE))
>      api.distance = stream_getc (s);
>    else

-- 
    Denis Ovsienko



More information about the Quagga-dev mailing list