[quagga-dev 8950] Re: [PATCH] check for errno after strtoul

Ulrich Weber ulrich.weber at Sophos.com
Thu Nov 17 15:02:15 GMT 2011


Hi Denis,

On 16.11.2011 16:49, Denis Ovsienko wrote:
>
> Hello.
>
> I have studied (the second revision of) it and see, that among other things you fix str2tag(), which looks completely broken in its present form. Besides that, route_match_metric_compile() uses its own way to detect a negative integer input, is there any special reason for that?
>
At the moment you can configure to match for negative metric numbers in 
route maps.
In my opinion this makes no sense, you can only set positive metrics.

Increasing/Decreasing metrics with route maps with a certain value is
not affected by this patch.

>> Third one sets maximum allowed number of ripng_timers to 65535,
>> as the documented maximum value. Or is the documentation wrong?
> Would VTY_GET_INTEGER_RANGE() be a better mean to use in ripng_timers()?
>
Yes you are right, makes more sense to use VTY_GET_INTEGER_RANGE here.
Attached new version of this patch.

Cheers
Ulrich

-- 
Ulrich Weber | ulrich.weber at sophos.com | Senior Software Engineer
Astaro - a Sophos company | Amalienbadstr 41 | 76227 Karlsruhe | Germany
Phone +49-721-25516-0 | Fax –200 | www.astaro.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ripngd-limit-max-of-timers-basic-to-65535_v2.patch
Type: text/x-patch
Size: 1611 bytes
Desc: not available
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20111117/f85d8b58/attachment-0001.bin>


More information about the Quagga-dev mailing list