[quagga-dev 8954] Re: [PATCH] ospf6d: account for IPv6 headers in MTU checks

John W. O'Brien john at saltant.com
Sat Nov 26 15:20:55 GMT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/17/2011 01:05 PM, Dmitrij Tejblum wrote:
> John W. O'Brien wrote:
>> This patch accounts for the essential header only, and not for
>> permissible extra headers which can still induce fragmentation. A
>> complete resolution would require additional information from the
>> kernel which is not generally available.
> Yes, your fix looks correct. Actually, the very similar patch has been
> committed to the RE-testing-0.99 branch few months ago, but,
> unfortunately, it was not merged to master until now. I have just merged
> it.
> 
> (The 'release engineering process' we follow is described at
> http://sourceforge.net/apps/mediawiki/quagga/index.php?title=ReleaseEngineering

Dmitrij,

Yes, I agree that the accepted patch [1] appears, upon inspection, to be
functionally identical to the patch I proposed, though I have not had
(and probably will not have for a while) a chance to test it. I also
appreciate that ospf6_packet_max() provides a desirable decoupling
point, for when Quagga learns how to discover the presence of extra headers.

Cheers,
John

[1] quagga.git:
ospf6d: check MTU with message header size in mind
681b84e8f50a09ff871d9e6536e8d8afb115ce13

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJO0QPVAAoJEEdKvTwaez9wxDUIALAPe09VknKHGKHXjsw5MDUN
u/6rrl1UERXqSFnG/toC9oqQYWSyiu1E851J7450PGCc3ViZDotbJdqsGcce/OsI
sNabiU6hU0FPXXETAJsGs3al51Nk2plfXFdyvQiBLMXmktBUvcPUd8YWLI527/Sp
7a7VBc/J20dmO/KIiFVeBOwGkVxGA7gUDKyUKcQz+h94S1TsX+jx98GM3YiwWRVy
WVPy5FF/PUg9Mg5Jdoy0vaZzQ/W4MUzdUdeP/VjradEqVzMZZtiF2KZCdTw826Pl
pT/98eIaCc9caTPj8PbDDJaOibQYMdO9IRh5qnCVBkWN9+OkWLcxuHUxWPaxJlo=
=6wqI
-----END PGP SIGNATURE-----



More information about the Quagga-dev mailing list