[quagga-dev 8819] Re: [PATCH 1/2] lib: Optimize Fletcher and Internet checksums

Joakim Tjernlund joakim.tjernlund at transmode.se
Thu Sep 8 15:58:46 BST 2011


Paul Jakma <paul at jakma.org> wrote on 2011/09/08 14:52:37:
>
> On Thu, 8 Sep 2011, Joakim Tjernlund wrote:
>
> > Just found out that the odd byte handling in my patch is wrong for BE
> > archs(even the RFC got this wrong apparently)
>
> So I was justified in not accepting this patch because it had no unit
> test? :)

Hey, you took my unit code test but ignored the patch :)
The unit test is flawed though as the RFC got it wrong too.

 Jocke




More information about the Quagga-dev mailing list