[quagga-dev 8820] Re: [PATCH 1/2] lib: Optimize Fletcher and Internet checksums

Paul Jakma paul at jakma.org
Thu Sep 8 17:38:00 BST 2011


On Thu, 8 Sep 2011, Joakim Tjernlund wrote:

> Hey, you took my unit code test but ignored the patch :)

Perhaps then cause the performance benefits hadn't been demonstrated? :)

> The unit test is flawed though as the RFC got it wrong too.

It'd be worth documenting the issues in the code. It's pretty damn subtle 
code - at least it seems both of us now have missed such subtleties..

regards,
-- 
Paul Jakma	paul at jakma.org	Key ID: 64A2FF6A
Fortune:
Just because your doctor has a name for your condition doesn't mean he
knows what it is.



More information about the Quagga-dev mailing list