[quagga-dev 9361] Re: [PATCH] don't ignore netlink packets apparently coming from the command socket

Greg Troxel gdt at ir.bbn.com
Tue May 22 17:44:20 BST 2012


Torsten Luettgert <st-quagga at luettgert.de> writes:

> Hi list,
>
> under linux > 2.6.18, quagga (all versions) would not remove the
> "directly connected" state routes when IP addresses were removed from
> interfaces in vtysh.
>
> My "fix" was to remove the block checking if the message has the same
> pid as the command interface. I hope this doesn't make zebra parse lots
> of irrelevant messages.

Do you understand how the netlink socket was supposed to work?   Can you
explain why this is a quagga bug vs. a Linux bug?  (I'm not saying I
think it *is* a Linux bug, just that I don't see an explanation of how
things ought to be and why, and your putting fix in quotes make me
suspicious that the change is a workaround rather than a fix.)

I would think all notifications from the kernel that state is changing
should be parsed.  But I have also heard that netlink is unreliable, and
I had the (very vague) impression that messages to the kernel were acted
on to work around that.

Really what I'm trying to say is that it would be good if someone really
understood what was going on here, so we could be sure that any changes
were actually right.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20120522/25d89a11/attachment-0001.sig>


More information about the Quagga-dev mailing list