[quagga-dev 9368] Re: [PATCH 25/25] lib: optimize IPV4_ADDR_[SAME|COPY]()

David Lamparter equinox at opensourcerouting.org
Tue May 22 23:46:22 BST 2012


On Wed, May 23, 2012 at 12:29:23AM +0200, David Lamparter wrote:
> On Tue, May 08, 2012 at 08:40:48AM +0200, Joakim Tjernlund wrote:
> > 
> > >
> > > From: "Jorge Boncompte [DTI2]" <jorge at dti2.net>
> > >
> > > * lib/prefix.c: (prefix_same) changed to use prefix4 field.
> > > * ospfd/ospf_packet.c: (ospf_ls_upd_send) changed to use prefix4 field.
> > >
> > >   Now that all callers use the prefix4 field...
> > >
> > > * lib/prefix.h: use assignment and comparison instead of memcpy() and
> > >   memcmp(). Avoids function calls. Much faster.
> > >
> > > Signed-off-by: Jorge Boncompte [DTI2] <jorge at dti2.net>
> > 
> > You might want to look at my old patch:
> > 
> > http://lists.quagga.net/pipermail/quagga-dev/2009-November/007376.html
> > 
> > Is it a more complete version of this one.
> 
> I'll pick it up after rechecking the BGP remote ID thing.  I think the
> check is actually 100% wrong and removing it was the correct fix in the
> first place, but I'll recheck.

Actually, that ends up being the idea of "bgpd: don't advertise routes
with peer address as nexthop";  I'll go respin that using peer->nexthop
as I've commented already.  After reading RFC4271 5.1.3 I'm confident
that's actually the correct thing to do.

-David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: Digital signature
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20120523/e41789bb/attachment-0001.sig>


More information about the Quagga-dev mailing list