[quagga-dev 9957] Re: [PATCH] testzebra: pragma weak: detect systems with weak alias and provide alternative

David Lamparter equinox at diac24.net
Mon Nov 5 15:53:00 GMT 2012


On Thu, Oct 11, 2012 at 09:29:04PM +0300, Hasso Tepper wrote:
> Doug VanLeuven wrote:
> > I just have to try.
> > 
> > LLVM clang does not support #pragma weak (bug 3679) on OS X.There are other
> > systems where the #pragma weak has varying syntax.
> > I was ableto get weak alias to work inside one compilation uniton OS X,
> > but not across object file boundaries.
> > 
> > Added m4 file from the autoconf archives:
> > http://www.gnu.org/software/autoconf-archive/ax_sys_weak_alias.html
> > 
> > Fix up zebra/*_null.c files to use #pragma weak alias
> > or stub functions if not available. It's incomplete in that the different
> > format #pragma #ifdef's for HP, Solaris, and Cray have not been included,
> > but would enable easier fixes on need.
> 
> But the current breaks all these systems ;). You must test for
> HAVE_SYS_WEAK_ALIAS_PRAGMA being defined, not HAVE_SYS_WEAK_ALIAS.

Doug, can you address this, retest and submit a new patch?

-David



More information about the Quagga-dev mailing list