[quagga-dev 10447] Re: OSPF: External Prefix Summarization
troglobit at gmail.com
Sat Apr 20 11:38:34 BST 2013
I have been trying out your excellent piece of code. This contribution
of yours is what I've wanted to do myself for a long time now. So I'm
very interested in helping out as much as I can and have time for it!
First off, it works! \o/
I tried it out on my laptop against one of our¹ own Quagga based
routers and the laptop happily summarized a set of /24 nets I had
setup on loopback and redistributed them as one /16 as I had
instructed it to do.
However, in my telnet session with ospfd I cannot seem to get the
summary-address setting to be saved in ospfd.conf, or see it in
Maybe you've forgotten to add some code for that?
When I add the summary-address line manually to ospfd.conf and
restart ospfd it also works, even though it leaks the following line to
Summary route for 10.0.0.0 added.
I guess that should be silent when starting up in non-interactive mode.
But there's still no "summary-address ..." line in "show running" when
I telnet back into ospfd.
There is also a couple of minor whitespace issues in the code, I can
followup with a patch on that if you like.
¹) I work at Westermo R&D, we do switches/routers and stuff
On 04/16/2013 10:24 PM, Ján Janovic wrote:
> thanks for fast reply. I have made my own git repository at BitBucked
> today by cloning quagga's master branch. I hope it will be sufficient.
> You can find it here:
> feature branch: ospfd/ext_summarization
> There is a quite extensive peace of code edited/added, I've added
> comments on many lines. If you have specific questions or suggestions,
> please write it here. I would like to discuss this solution and make
> it better.
> The part of idea for external summarization is taken from ABR
> summarization between areas. I've tried to use as much of existing
> code/functions as I could.
> All information about summary prefix is stored in new structure
> ospf_external_summary_prefixes defined in ospfd.h. Logic is written in
> files ospf_vty.c(DEFUNs) and ospf_zebra.c(ospf_zebra_read_ipv4()).
> Tested for now on Ubuntu, with a topology made from Cisco routers
> running in Dynamips.
> Thanks in advance for review.
> Jan Janovic
> On 04/15/2013 07:15 PM, Greg Troxel wrote:
>> Feel free to post code here.
>> Also, if you have a git repository with your code on a feature branch,
>> and others can clone it, that would be best.
More information about the Quagga-dev