[quagga-dev 10284] Re: [PATCH 2/3] tests: DejaGNU bgpd

David Lamparter equinox at opensourcerouting.org
Wed Feb 27 10:33:17 GMT 2013


On Tue, Feb 26, 2013 at 07:04:43PM +0100, David Lamparter wrote:
> this just wraps the existing test programs in expect wrappers that make
> their results usable to DejaGNU.
> 
> Signed-off-by: David Lamparter <equinox at opensourcerouting.org>
> ---
>  configure.ac                       |  1 +
>  tests/Makefile.am                  |  7 ++--
>  tests/bgpd.tests/Makefile.am       |  7 ++++
>  tests/bgpd.tests/aspathtest.exp    | 76 ++++++++++++++++++++++++++++++++++++++
>  tests/bgpd.tests/ecommtest.exp     | 13 +++++++
>  tests/bgpd.tests/testbgpcap.exp    | 51 +++++++++++++++++++++++++
>  tests/bgpd.tests/testbgpmpath.exp  | 12 ++++++
>  tests/bgpd.tests/testbgpmpattr.exp | 31 ++++++++++++++++
>  8 files changed, 195 insertions(+), 3 deletions(-)
>  create mode 100644 tests/bgpd.tests/Makefile.am
>  create mode 100644 tests/bgpd.tests/aspathtest.exp
>  create mode 100644 tests/bgpd.tests/ecommtest.exp
>  create mode 100644 tests/bgpd.tests/testbgpcap.exp
>  create mode 100644 tests/bgpd.tests/testbgpmpath.exp
>  create mode 100644 tests/bgpd.tests/testbgpmpattr.exp
> 
> diff --git a/configure.ac b/configure.ac
> index 582f357..32a59d9 100755
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1704,6 +1704,7 @@ AC_CONFIG_FILES([Makefile lib/Makefile zebra/Makefile ripd/Makefile
>  	  ripngd/Makefile bgpd/Makefile ospfd/Makefile watchquagga/Makefile
>  	  ospf6d/Makefile isisd/Makefile babeld/Makefile vtysh/Makefile
>  	  doc/Makefile ospfclient/Makefile tests/Makefile m4/Makefile
> +	  tests/bgpd.tests/Makefile
>  	  redhat/Makefile
>  	  pkgsrc/Makefile
>  	  redhat/quagga.spec 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 14f7bef..153922b 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -1,14 +1,14 @@
>  AUTOMAKE_OPTIONS    = dejagnu
>  export DEJAGNU
> +DEJATOOL =
>  
> -SUBDIRS =
> +SUBDIRS = bgpd.tests
>  
>  EXTRA_DIST = \
>  	config/unix.exp \

> +	lib/bgpd.exp \

I forgot to include this file (which is empty anyway but heh...) in the
patch.  I've respun it.

I'm a bit unsure about the feedback.  If someone can suggest a better
test framework, please do so... but please don't suggest _unit_ test
frameworks, those are a different thing (that we should also be using,
but one thing at a time).

Deadline for comments/suggestions is Friday 24:00 UTC.


-David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: Digital signature
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130227/536c57b8/attachment-0001.sig>


More information about the Quagga-dev mailing list