[quagga-dev 10152] Re: Zebra and Netlink (for LDP)

Stephen Hemminger shemminger at vyatta.com
Mon Jan 7 16:20:00 GMT 2013


On Mon, 7 Jan 2013 15:31:36 +0100
David Lamparter <equinox at opensourcerouting.org> wrote:

> On Wed, Dec 19, 2012 at 01:51:36PM +0200, Timo Teras wrote:
> > It appears that Renato just somehow pulled in the netlink libraries
> > from iproute2. But since we have most of that zebra/rt_netlink.c. And
> > seems that in commit 78deec4 "zebra: extern/extract some functions from
> > rt_netlink.c" some of those were already exposed.
> > 
> > I would need even more additional functions and things from there. So
> > would it be feasible to separate those to "libnetlink.c" or some
> > similar thing? Or just keep exporting stuff from rt_netlink.c?
> 
> I'd say it's preferable to reduce the amount of code maintained in
> Quagga where reasonably possible.  In this case we could either try and
> pull entire files from iproute2 (whole files are easiest to keep in sync
> in case someone fixes something upstream...) or alternatively remove it
> from Quagga and use an external library.  Picking one instead of mixing
> would certainly be appreciated...
> 
> Renato had asked about libmnl, I think that was a good idea since it
> mimics the kernel API and is relatively low-level.  With libnl on the
> other hand I've made very negative experiences myself.  iproute2's
> libnetlink, OTOH, is supposed to be an internal library and isn't
> installed by default.  Debian doesn't have it in the package, Gentoo
> does...
> 
> So, order of prettyness:
> 1. libmnl
> 2. libnetlink, linked as external library
> 3. 1:1 import copy of libnetlink
> 4. partial import copy of libnetlink
> 5. mixture of any of the above
> 6. libnl
> 

My preference is to just use libmnl as well. The only issue would be
the added dependency for people running on ancient distros.

If there are no volunteers, I'll do it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130107/9315d0fa/attachment-0001.sig>


More information about the Quagga-dev mailing list