[quagga-dev 10175] Re: [PATCH] bgpd: fix for leaked struct bgp_adj_[in|out] on peer shutdown

David Lamparter equinox at opensourcerouting.org
Mon Jan 14 14:19:42 GMT 2013


On Mon, Jan 14, 2013 at 01:18:01PM +0100, David Lamparter wrote:
> On Mon, May 07, 2012 at 06:17:33PM +0200, Jorge Boncompte [DTI2] wrote:
> > From: "Jorge Boncompte [DTI2]" <jorge at dti2.net>
> > 
> >     If a peer with soft-reconfiguration configured it's cleared, the
> > function bgp_clear_route_table() doesn't free the bgp_adj_in and bgp_adj_out
> > structures of route nodes that for some reason, ej. denied by a filter,
> > don't have routes attached "rn->info == NULL".
> 
> I've thrown this to Leonid for review, he agrees with the first part and
> is neutral on the second part.  (By the way, this should really have
> been two patches, I'll split it up on import.)
> 
> Reviewed-by: Leonid Rosenboim <Leonid.Rosenboim at windriver.com>
> 
> So I'm picking this up for 0.99.22.
> (Now going through the backlog on bgpd, starting on this.)

Split in 2 and both applied.  Thanks Jorge & Leonid!

-David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: Digital signature
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130114/d4076afd/attachment-0001.sig>


More information about the Quagga-dev mailing list