[quagga-dev 10176] Re: IPv6 BGP md5 password disappears on restart

David Lamparter equinox at opensourcerouting.org
Mon Jan 14 14:26:27 GMT 2013


On Mon, Aug 06, 2012 at 02:44:37PM +0200, Roman Hoog Antink wrote:
> This way the order of group and password statements is unimportant and
> all scenarios are possible: peers with individual passwords overriding
> group passwords; peers with individual passwords in groups without group
> password, etc.

[...]
>    /* password apply */
> -  if (peer->password)
> -    XFREE (MTYPE_PEER_PASSWORD, peer->password);
> -
>    if (conf->password)
> -    peer->password =  XSTRDUP (MTYPE_PEER_PASSWORD, conf->password);
> -  else
> -    peer->password = NULL;
> +    {
> +      XFREE (MTYPE_PEER_PASSWORD, peer->password);
> +      peer->password =  XSTRDUP (MTYPE_PEER_PASSWORD, conf->password);
> +    }

Shouldn't this be "if (conf->password && !peer->password)"?

Even with your patch, if the peer-group has a password set, that will
override the peer's password, if it's set before the peer is added to
the peer group - or am I overlooking something?

-David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: Digital signature
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130114/eda04024/attachment-0001.sig>


More information about the Quagga-dev mailing list