[quagga-dev 10187] Re: [PATCH] Quagga needs to send notification, then close TCP on failed OPEN

David Lamparter equinox at opensourcerouting.org
Tue Jan 15 16:28:28 GMT 2013


On Fri, Dec 07, 2012 at 10:19:16PM +0000, Rosenboim, Leonid wrote:
> Reference:	OSRQUAGGA-52
> ANVL opens TCP session, but without opening sends KEEPALIVE. Quagga needs to send NOTIFICATION, then close session
> 
> -------------------------- Patch 1 of 2 -----------------------------------------------------
> commit a13ac58efa0e056583d0c6b09c78a3bc99ef2cf8
> Author: Leonid Rosenboim <lrosenbo at wrs.com>
> Date:   Tue Nov 20 17:22:13 2012 -0800
> 
>     [OSRQUAGGA-52] Send NOTIFY on KEEPALIVE before OPEN packet
>     
>     The test case shows one case where the code circumvents the FSM,
>     and so in order to get the correct FSM transition to work, the
>     packet receive processing function had to be corrected.
>     
>     A distinction has been made between handling of malformed packet
>     errors, and normal exits. The packet receiving code may need additional
>     work still.
[...]
> @@ -970,7 +1001,7 @@ static const struct {
>      {bgp_fsm_holdtime_expire, Idle},	/* Hold_Timer_expired           */
>      {bgp_ignore,  Idle},	/* KeepAlive_timer_expired      */
>      {bgp_fsm_open,    OpenConfirm},	/* Receive_OPEN_message         */
> -    {bgp_ignore,  Idle},	/* Receive_KEEPALIVE_message    */
> +    {bgp_fsm_event_error, Idle},/* Receive_KEEPALIVE_message    */
>      {bgp_ignore,  Idle},	/* Receive_UPDATE_message       */
>      {bgp_stop_with_error, Idle}, /* Receive_NOTIFICATION_message */
>      {bgp_ignore, Idle},         /* Clearing_Completed           */

This addresses only exactly the ANVL test.  What behaviour should we
exhibit on getting other packets before OPEN, i.e. an UPDATE?

Not applying this fix; it cosmetically hides a single testcase issue
instead of addressing the actual problem...


-David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: Digital signature
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130115/1029cbf8/attachment-0001.sig>


More information about the Quagga-dev mailing list