[quagga-dev 10198] Re: [PATCH] zebra: fix sockaddr_dl length assumptions (BZ#737)

David Lamparter equinox at opensourcerouting.org
Tue Jan 15 19:18:02 GMT 2013


On Tue, Jan 15, 2013 at 05:34:13PM +0100, Matthias-Christian Ott wrote:
> On 2013-01-15 17:18, David Lamparter wrote:
> 
> > applying this version now.  the "we have no sdl_len" path is a bit unfortunate,
> > if we hit it on anything other than Solaris (with sdl_data[244]), it'll break.
> 
> You should probably use a named dummy union, because anonymous unions
> are standardised as part of C11 (although GCC supported them prior to that).

We don't support compilers other than gcc, clang and icc anyway...
(e.g. use of __builtin_clz in ip_masklen())


-David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: Digital signature
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130115/dab1a049/attachment-0001.sig>


More information about the Quagga-dev mailing list