[quagga-dev 10208] Re: [PATCH] BGP: Quagga does not send notification if invalid (too long) message is received

Stephen Hemminger stephen at networkplumber.org
Wed Jan 16 16:43:22 GMT 2013


On Wed, 16 Jan 2013 01:39:04 +0100
David Lamparter <equinox at opensourcerouting.org> wrote:

> On Fri, Dec 14, 2012 at 08:12:17PM +0000, Rosenboim, Leonid wrote:
> >     [OSRQUAGGA-84] Push out NOTIFY message before closing a connection
> >     
> >     Prevent TCP_CORK bandwidth optimization code to cause a NOTIFY message
> >     dissapear prior to when the connection is closed.
> 
> So, even though this is a patch from "bad" to "a little less bad", it is
> correct nonetheless.
> 
> Applied (with reformatted patch description),  Thanks!
> 
> -David

This patch is unnecessary after my patch to not leave socket
in corked state. The socket should also stay in non-blocked mode,
if it is flow blocked then too bad, because as David said, the
NOTIFY message is advisory.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130116/0dcd49cd/attachment-0001.sig>


More information about the Quagga-dev mailing list