[quagga-dev 10587] Re: OSPF: External Prefix Summarization

Joachim Nilsson troglobit at gmail.com
Tue Jul 9 12:00:04 BST 2013


Hi Ján, everyone!

It took me a while to get around to, but this neat functionality
has now been tested and verified OK! :-)

router ospf
   network 172.16.10.0/24 area 0.0.0.1
   area 0.0.0.1 nssa
   redistribute rip
   summary-address 10.0.0.0/8        <---- NEW

There are of course always minor things that can be improved
upon, like supporting alternative syntaxes, nitpick GNU coding
styles and documentation details, but all in all this fine piece of
code belongs in Quagga.

It is also a missing feature that many people want, so after
having read the code, and tested it quite thoroughly, I'd like
to give my full recommendations for adding summary-address
support to OSPF.

Signed-off-by: Joachim Nilsson <troglobit at gmail.com>

Regards
  /Joachim

On 05/06/2013 08:11 PM, Ján Janovic wrote:
> Hello again!
>
> It should be done according to your instructions, Joachim :)
>
> Now, there is only one, squashed commit for feature branch 
> ospfd/ext_summarization with edited documentation and GNU coding style 
> applied. You can access it directly here:
>
> https://bitbucket.org/janovic/quagga/commits/3e4a81207ae87f13d0a8be3ce0145618cd5b19e2
>
> or you can clone whole repository:
>
> git clone https://janovic@bitbucket.org/janovic/quagga.git
>
> Please, review it and send your response. Thanks for the big support 
> with this feature.
>
> Regards
> Jan Janovic
>
>
> On 05/06/2013 01:18 AM, Joachim Nilsson wrote:
>> Hi again Ján!
>>
>> Sorry for the delay, like I said in our private conversation, it's 
>> been quite a busy couple of weeks at work. I've just tested the 
>> latest fixes tonight, and it works great! :-)
>>
>> A more click-friendly URL to Ján's OSPF summary-address is here:
>>
>> https://bitbucket.org/janovic/quagga/commits/all
>>
>> Like I mentioned privately, if you:
>>
>>     1. Squash the commits,
>>     2. Add texinfo documentation for the summary-address cmd, and
>>     3. Make some minor GNU coding style fixups
>>
>> then I'd be more than happy to sign off on your work! :-)
>>
>> Best regards
>>  /Joachim
>>
>> On 04/23/2013 12:06 AM, Ján Janovic wrote:
>>> Hi everybody.
>>>
>>> I have updated my feature branch ospfd/ext_summarization at
>>>
>>> https://janovic@bitbucket.org/janovic/quagga.git
>>>
>>> Today I resolved all issues we talked about in this thread with 
>>> Joachim. To be specific:
>>> * summary-address command and its variation are now correctly saved 
>>> to config file
>>> * discard route is added for every configured summary route
>>> * message "summary route for ... added" now appears only while debug 
>>> ospf events is on
>>>
>>> @Joachim: Could you please test it like before? I very appreciate 
>>> any help.
>>>
>>> @David: I've noticed from mailing list and git commits that you are 
>>> quite "in charge" here. Can you please give me some instructions, 
>>> what should I do next with code to get closer to the official 
>>> release? I think it could be interesting and useful contribution :)
>>>
>>> Thanks in advance.
>>> Regards.
>>> Jan Janovic
>>>
>>>
>>> On 04/21/2013 06:45 PM, Joachim Nilsson wrote:
>>>> On 04/21/2013 03:30 PM, Ján Janovic wrote:
>>>>> There is a one more idea in my head. Maybe you(or somebody else) 
>>>>> could help me with
>>>>> that. As you know for sure, when you start summarization on Cisco 
>>>>> devices,
>>>>> "discard" summary route is added to route table to prevent routing 
>>>>> loops.
>>>>> Is there a possibility to add such a route in linux? And from 
>>>>> Quagga code?
>>>>
>>>> Or is it a null route you're referring to?
>>>>
>>>> zebra.conf:
>>>>     ip route 0.0.0.0 tun0
>>>>     ip route 0.0.0.0 eth0 10
>>>>     ip route 0.0.0.0 null0 255
>>>>
>>>> If tun0 is up it runs as default gateway, otherwise, eth0 and as a 
>>>> last resort
>>>> the null0 route will act as a blackhole.
>>>>
>>>> Regards
>>>>  /Joachim
>>>>
>>>>
>>
>>
>> _______________________________________________
>> Quagga-dev mailing list
>> Quagga-dev at lists.quagga.net
>> http://lists.quagga.net/mailman/listinfo/quagga-dev
>>
>>
>
>
>
>
>
> _______________________________________________
> Quagga-dev mailing list
> Quagga-dev at lists.quagga.net
> http://lists.quagga.net/mailman/listinfo/quagga-dev





More information about the Quagga-dev mailing list