[quagga-dev 10588] Re: [PATCH 3/5] zebra: implement NEXTHOP_FLAG_ONLINK

Greg Troxel gdt at ir.bbn.com
Tue Jul 9 14:44:53 BST 2013


Christian Franke <chris at opensourcerouting.org> writes:

> On 07/05/2013 07:21 PM, Michael H Lambert wrote:
>> On 5 Jul 2013, at 12:35, Christian Franke <chris at opensourcerouting.org> wrote:
>> 
>>> On Linux, the kernel will only allow for a route to be installed when
>>> its gateway is directly attached according the kernel fib.
>> 
>> Should the changes to zebra/zebra_vty.c be conditionalized to only
>> build under Linux or are they safe (and not misleading) on other
>> platforms?
>
> The changes should not break anything for other platforms.
>
> The worst thing that may happen is that a nexthop shows up as "onlink"
> in the RIB but does not actually get installed as "onlink" into the FIB.
>
> Imho that solution is preferrable to introducing #ifdefs but if there is
> a concensus that we should have that #ifdefed, so be it.

Have you tested on a BSD?  It sounds like you haven't, but that seems
surprising for such a large change.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130709/807302cb/attachment-0001.sig>


More information about the Quagga-dev mailing list