[quagga-dev 10589] Re: [PATCH 3/5] zebra: implement NEXTHOP_FLAG_ONLINK

Christian Franke nobody at nowhere.ws
Tue Jul 9 16:38:36 BST 2013


On 07/09/2013 03:44 PM, Greg Troxel wrote:
> 
> Christian Franke <chris at opensourcerouting.org> writes:
>> The changes should not break anything for other platforms.
>> 
>> The worst thing that may happen is that a nexthop shows up as
>> "onlink" in the RIB but does not actually get installed as
>> "onlink" into the FIB.
>> 
>> Imho that solution is preferrable to introducing #ifdefs but if
>> there is a concensus that we should have that #ifdefed, so be
>> it.
> 
> Have you tested on a BSD?  It sounds like you haven't, but that
> seems surprising for such a large change.

I have tested it on Linux and on FreeBSD, there, I was unable to find
any regressions. (I wrote some integration tests and did code
coverage, any code I touched was covered by the tests)

I also checked that it compiles on Solaris and works there.

For NetBSD and OpenBSD I currenly don't have any test machines, so I
wasn't yet able to test it there.

The biggest part of the changes is in the platform independend RIB
code, the changes to the platform depended part are mostly
straightforward so I am somewhat confident that they shouldn't break
support for those platforms.

-Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: OpenPGP digital signature
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130709/cc2255f4/attachment-0001.sig>


More information about the Quagga-dev mailing list