[quagga-dev 10598] Re: [PATCH 2/2] tests: don't build tests unless make check is run

David Lamparter equinox at opensourcerouting.org
Mon Jul 15 13:48:21 BST 2013


On Tue, Jul 09, 2013 at 12:34:21PM -0400, Greg Troxel wrote:
> Christian Franke <chris at opensourcerouting.org> writes:
> 
> > Use check_PROGRAMS instead of noinst_PROGRAMS in tests/Makefile.am
> > to build the tests only when make check is actually run.
> 
> David said he didn't like this, but I'm in favor of taking your patch.
> While I'm sympathetic about keeping the check programs building by
> making everyone build them whenever they build quagga, the real value is
> in running 'make test', which will build these.  And I don't think this
> is good enough justification to depart from the standard approach.
> 
> Opinions from others?

Christian and Greg are in favour of this, my dislike is weak in that it
contains a "for now", i.e. my preference was only to this happening
later, not to this not happening at all.  In summary, I guess we'll take
it now.


-David

(Not picking it up right now, other stuff has priority -- Greg, feel free...)




More information about the Quagga-dev mailing list