[quagga-dev 10602] Re: [PATCH 2/2] tests: don't build tests unless make check is run

David Lamparter equinox at opensourcerouting.org
Mon Jul 15 14:30:02 BST 2013


On Mon, Jul 15, 2013 at 09:09:11AM -0400, Greg Troxel wrote:
> David Lamparter <equinox at opensourcerouting.org> writes:
> > On Tue, Jul 09, 2013 at 12:34:21PM -0400, Greg Troxel wrote:
> >> Christian Franke <chris at opensourcerouting.org> writes:
> >> 
> >> > Use check_PROGRAMS instead of noinst_PROGRAMS in tests/Makefile.am
> >> > to build the tests only when make check is actually run.
> >> 
> >> David said he didn't like this, but I'm in favor of taking your patch.
> >> While I'm sympathetic about keeping the check programs building by
> >> making everyone build them whenever they build quagga, the real value is
> >> in running 'make test', which will build these.  And I don't think this
> >> is good enough justification to depart from the standard approach.
> >> 
> >> Opinions from others?
> >
> > Christian and Greg are in favour of this, my dislike is weak in that it
> > contains a "for now", i.e. my preference was only to this happening
> > later, not to this not happening at all.  In summary, I guess we'll take
> > it now.
> 
> I ran a build with the patch, and it behaved as expected, so I have
> pushed it to master.
> 
> make check, however, fails to actually run, as it doesn't find
> "runtest".  I have all the dependencies documented in README.quagga.txt,
> so it seems there is something missing.

That would be DejaGNU, sorry, I didn't get to replying to your earlier
question about this.
(since dejagnu is oh so well integrated into autotools, I expected that
it would tell you that you need dejagnu... but... guess not.)

Considering that we switched to python for new tests @ OSR, I don't
believe DejaGNU is around to stick.  Tcl/expect is a royal pain in the
a** anyway, moving the test wrappers to Python should work out better.
Also lets us get rid of one scripting language of the three and a half
we currently use ;).  (third being perl, the half being awk... though
admittedly python isn't used yet)


-David




More information about the Quagga-dev mailing list