[quagga-dev 10633] Re: [PATCH 1/2] lib: fix possible off-by-one in stream_put_prefix()

Greg Troxel gdt at ir.bbn.com
Wed Jul 31 17:14:24 BST 2013


"Jorge Boncompte [DTI2]" <jorge at dti2.net> writes:

> -  
> +

In general, patch guidelines ask that patches not make unnecessary
changes to whitespace.  In this particular case, the changes are adding
leading white to blank lines, which shouldn't happen anyway.

  -  stream_putc (s, p->prefixlen);
  +  s->data[s->endp++] = p->prefixlen;

I don't understand why it's necessary to open-code the function call
here.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://lists.quagga.net/pipermail/quagga-dev/attachments/20130731/b0cf56da/attachment-0001.sig>


More information about the Quagga-dev mailing list