[quagga-dev 10634] Re: [PATCH 1/2] lib: fix possible off-by-one in stream_put_prefix()

Jorge Boncompte [DTI2] jorge at dti2.net
Wed Jul 31 17:51:35 BST 2013


El 31/07/2013 18:14, Greg Troxel escribió:
> 
> "Jorge Boncompte [DTI2]" <jorge at dti2.net> writes:
> 
>> -  
>> +
> 
> In general, patch guidelines ask that patches not make unnecessary
> changes to whitespace.  In this particular case, the changes are adding
> leading white to blank lines, which shouldn't happen anyway.
> 
>   -  stream_putc (s, p->prefixlen);
>   +  s->data[s->endp++] = p->prefixlen;
> 
> I don't understand why it's necessary to open-code the function call
> here.
> 

	You are right. I'll resend without whitespace changes and a proper changelog
stating that there is an optimization included.

-- 
==============================================================
Jorge Boncompte - Ingenieria y Gestion de RED
DTI2 - Desarrollo de la Tecnologia de las Comunicaciones
--------------------------------------------------------------
C/ Abogado Enriquez Barrios, 5   14004 CORDOBA (SPAIN)
Tlf: +34 957 761395 / FAX: +34 957 450380
==============================================================
- There is only so much duct tape you can put on something
  before it just becomes a giant ball of duct tape.
==============================================================





More information about the Quagga-dev mailing list